FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 522 |
140 |
0 |
0 |
ca.uhn.hl7v2.app.HL7Service
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in ca.uhn.hl7v2.app.HL7Service.loadApplicationsFromFile(File): new java.io.FileReader(File) |
I18N |
DM_DEFAULT_ENCODING |
362 |
High |
ca.uhn.hl7v2.app.Responder
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to respInbound in ca.uhn.hl7v2.app.Responder.main(String[]) |
STYLE |
DLS_DEAD_LOCAL_STORE |
152 |
High |
| Dead store to inMessage in ca.uhn.hl7v2.app.Responder.main(String[]) |
STYLE |
DLS_DEAD_LOCAL_STORE |
144 |
Medium |
| Found reliance on default encoding in ca.uhn.hl7v2.app.Responder.main(String[]): new java.io.FileReader(File) |
I18N |
DM_DEFAULT_ENCODING |
134 |
High |
ca.uhn.hl7v2.conf.check.DefaultValidator
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in ca.uhn.hl7v2.conf.check.DefaultValidator.loadFile(String): new java.io.FileReader(File) |
I18N |
DM_DEFAULT_ENCODING |
653 |
High |
ca.uhn.hl7v2.conf.parser.ProfileParser
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in ca.uhn.hl7v2.conf.parser.ProfileParser.main(String[]): new java.io.FileReader(File) |
I18N |
DM_DEFAULT_ENCODING |
477 |
High |
| Found reliance on default encoding in ca.uhn.hl7v2.conf.parser.ProfileParser.parseClasspath(String): new String(byte[], int, int) |
I18N |
DM_DEFAULT_ENCODING |
145 |
High |
ca.uhn.hl7v2.conf.spec.RuntimeProfile
| Bug |
Category |
Details |
Line |
Priority |
| Read of unwritten field encodings in ca.uhn.hl7v2.conf.spec.RuntimeProfile.getEncodings(int) |
CORRECTNESS |
NP_UNWRITTEN_FIELD |
88 |
Medium |
| Read of unwritten field encodings in ca.uhn.hl7v2.conf.spec.RuntimeProfile.setEncodings(int, Encoding) |
CORRECTNESS |
NP_UNWRITTEN_FIELD |
214 |
Medium |
| Unwritten field: ca.uhn.hl7v2.conf.spec.RuntimeProfile.encodings |
CORRECTNESS |
UWF_UNWRITTEN_FIELD |
88 |
Medium |
ca.uhn.hl7v2.conf.spec.Specification
| Bug |
Category |
Details |
Line |
Priority |
| Read of unwritten field encodings in ca.uhn.hl7v2.conf.spec.Specification.getEncodings(int) |
CORRECTNESS |
NP_UNWRITTEN_FIELD |
144 |
Medium |
| Read of unwritten field encodings in ca.uhn.hl7v2.conf.spec.Specification.setEncodings(int, Encoding) |
CORRECTNESS |
NP_UNWRITTEN_FIELD |
154 |
Medium |
| Unwritten field: ca.uhn.hl7v2.conf.spec.Specification.encodings |
CORRECTNESS |
UWF_UNWRITTEN_FIELD |
144 |
Medium |
ca.uhn.hl7v2.conf.spec.message.AbstractComponent
| Bug |
Category |
Details |
Line |
Priority |
| ca.uhn.hl7v2.conf.spec.message.AbstractComponent.setLength(long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
279 |
Medium |
ca.uhn.hl7v2.conf.spec.message.Field
| Bug |
Category |
Details |
Line |
Priority |
| ca.uhn.hl7v2.conf.spec.message.Field.setItemNo(short) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
119 |
Medium |
ca.uhn.hl7v2.conf.spec.message.Seg
| Bug |
Category |
Details |
Line |
Priority |
| ca.uhn.hl7v2.conf.spec.message.Seg.setMax(short) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
294 |
Medium |
ca.uhn.hl7v2.conf.spec.message.SegGroup
| Bug |
Category |
Details |
Line |
Priority |
| ca.uhn.hl7v2.conf.spec.message.SegGroup.setMax(short) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
194 |
Medium |
ca.uhn.hl7v2.conf.store.FileProfileStore
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in ca.uhn.hl7v2.conf.store.FileProfileStore.getProfile(String): new java.io.FileReader(File) |
I18N |
DM_DEFAULT_ENCODING |
48 |
High |
| Found reliance on default encoding in ca.uhn.hl7v2.conf.store.FileProfileStore.persistProfile(String, String): new java.io.FileWriter(File) |
I18N |
DM_DEFAULT_ENCODING |
73 |
High |
ca.uhn.hl7v2.conf.store.URLProfileStore
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in ca.uhn.hl7v2.conf.store.URLProfileStore.getProfile(String): new java.io.InputStreamReader(InputStream) |
I18N |
DM_DEFAULT_ENCODING |
58 |
High |
ca.uhn.hl7v2.model.AbstractMessage
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of ca.uhn.hl7v2.model.AbstractMessage.getParser(), which is known to be non-null in ca.uhn.hl7v2.model.AbstractMessage.instantiateACK() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
242 |
Medium |
ca.uhn.hl7v2.model.Field
| Bug |
Category |
Details |
Line |
Priority |
| new ca.uhn.hl7v2.model.Field(Type[], int) may expose internal representation by storing an externally mutable object into Field.reps |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
44 |
Medium |
| Unread field: ca.uhn.hl7v2.model.Field.maxCardinality |
PERFORMANCE |
URF_UNREAD_FIELD |
45 |
Medium |
ca.uhn.hl7v2.model.Unmodifiable$Delegating
ca.uhn.hl7v2.model.Unmodifiable$UnmodifiableMessage
| Bug |
Category |
Details |
Line |
Priority |
| ca.uhn.hl7v2.model.Unmodifiable$UnmodifiableMessage doesn't override Unmodifiable$Delegating.equals(Object) |
STYLE |
EQ_DOESNT_OVERRIDE_EQUALS |
1 |
Medium |
ca.uhn.hl7v2.model.v21.datatype.DT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v21.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-60 |
High |
ca.uhn.hl7v2.model.v21.datatype.ID
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v21.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
59-82 |
High |
ca.uhn.hl7v2.model.v21.datatype.TM
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v21.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
72-79 |
High |
ca.uhn.hl7v2.model.v22.datatype.DT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v22.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-60 |
High |
ca.uhn.hl7v2.model.v22.datatype.ID
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v22.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
59-82 |
High |
ca.uhn.hl7v2.model.v22.datatype.IS
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v22.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-76 |
High |
ca.uhn.hl7v2.model.v22.datatype.TM
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v22.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
72-79 |
High |
ca.uhn.hl7v2.model.v22.datatype.TSComponentOne
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v22.datatype.TSComponentOne shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TSComponentOne |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
89-96 |
High |
ca.uhn.hl7v2.model.v23.datatype.DT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v23.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-60 |
High |
ca.uhn.hl7v2.model.v23.datatype.ID
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v23.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
59-82 |
High |
ca.uhn.hl7v2.model.v23.datatype.IS
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v23.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-76 |
High |
ca.uhn.hl7v2.model.v23.datatype.TM
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v23.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
72-79 |
High |
ca.uhn.hl7v2.model.v23.datatype.TSComponentOne
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v23.datatype.TSComponentOne shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TSComponentOne |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
89-96 |
High |
ca.uhn.hl7v2.model.v231.datatype.DT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v231.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-60 |
High |
ca.uhn.hl7v2.model.v231.datatype.ID
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v231.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
59-82 |
High |
ca.uhn.hl7v2.model.v231.datatype.IS
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v231.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-76 |
High |
ca.uhn.hl7v2.model.v231.datatype.TM
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v231.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
72-79 |
High |
ca.uhn.hl7v2.model.v231.datatype.TSComponentOne
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v231.datatype.TSComponentOne shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TSComponentOne |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
89-96 |
High |
ca.uhn.hl7v2.model.v24.datatype.DT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v24.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-60 |
High |
ca.uhn.hl7v2.model.v24.datatype.ID
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v24.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
58-81 |
High |
ca.uhn.hl7v2.model.v24.datatype.IS
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v24.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-76 |
High |
ca.uhn.hl7v2.model.v24.datatype.TM
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v24.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
72-79 |
High |
ca.uhn.hl7v2.model.v24.datatype.TSComponentOne
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v24.datatype.TSComponentOne shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TSComponentOne |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
86-93 |
High |
ca.uhn.hl7v2.model.v25.datatype.DT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v25.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-60 |
High |
ca.uhn.hl7v2.model.v25.datatype.ID
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v25.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
58-81 |
High |
ca.uhn.hl7v2.model.v25.datatype.IS
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v25.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-76 |
High |
ca.uhn.hl7v2.model.v25.datatype.TM
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v25.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
72-79 |
High |
ca.uhn.hl7v2.model.v251.datatype.DT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v251.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-60 |
High |
ca.uhn.hl7v2.model.v251.datatype.ID
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v251.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
58-81 |
High |
ca.uhn.hl7v2.model.v251.datatype.IS
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v251.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-76 |
High |
ca.uhn.hl7v2.model.v251.datatype.NULLDT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v251.datatype.NULLDT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.NULLDT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
26-27 |
High |
ca.uhn.hl7v2.model.v251.datatype.TM
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v251.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
72-79 |
High |
ca.uhn.hl7v2.model.v26.datatype.DT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v26.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-60 |
High |
ca.uhn.hl7v2.model.v26.datatype.ID
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v26.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
58-81 |
High |
ca.uhn.hl7v2.model.v26.datatype.IS
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v26.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-76 |
High |
ca.uhn.hl7v2.model.v26.datatype.NULLDT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v26.datatype.NULLDT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.NULLDT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
26-27 |
High |
ca.uhn.hl7v2.model.v26.datatype.TM
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v26.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
72-79 |
High |
ca.uhn.hl7v2.model.v27.datatype.DT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v27.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-60 |
High |
ca.uhn.hl7v2.model.v27.datatype.ID
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v27.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
58-81 |
High |
ca.uhn.hl7v2.model.v27.datatype.IS
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v27.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-76 |
High |
ca.uhn.hl7v2.model.v27.datatype.NULLDT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v27.datatype.NULLDT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.NULLDT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
26-27 |
High |
ca.uhn.hl7v2.model.v27.datatype.TM
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v27.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
72-79 |
High |
ca.uhn.hl7v2.model.v271.datatype.DT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v271.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-60 |
High |
ca.uhn.hl7v2.model.v271.datatype.ID
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v271.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
58-81 |
High |
ca.uhn.hl7v2.model.v271.datatype.IS
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v271.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-76 |
High |
ca.uhn.hl7v2.model.v271.datatype.NULLDT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v271.datatype.NULLDT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.NULLDT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
26-27 |
High |
ca.uhn.hl7v2.model.v271.datatype.TM
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v271.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
72-79 |
High |
ca.uhn.hl7v2.model.v28.datatype.DT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v28.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-60 |
High |
ca.uhn.hl7v2.model.v28.datatype.ID
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v28.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
58-81 |
High |
ca.uhn.hl7v2.model.v28.datatype.IS
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v28.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-76 |
High |
ca.uhn.hl7v2.model.v28.datatype.NULLDT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v28.datatype.NULLDT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.NULLDT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
26-27 |
High |
ca.uhn.hl7v2.model.v28.datatype.TM
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v28.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
72-79 |
High |
ca.uhn.hl7v2.model.v281.datatype.DT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v281.datatype.DT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.DT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-60 |
High |
ca.uhn.hl7v2.model.v281.datatype.ID
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v281.datatype.ID shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.ID |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
58-81 |
High |
ca.uhn.hl7v2.model.v281.datatype.IS
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v281.datatype.IS shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.IS |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
53-76 |
High |
ca.uhn.hl7v2.model.v281.datatype.NULLDT
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v281.datatype.NULLDT shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.NULLDT |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
26-27 |
High |
ca.uhn.hl7v2.model.v281.datatype.TM
| Bug |
Category |
Details |
Line |
Priority |
| The class name ca.uhn.hl7v2.model.v281.datatype.TM shadows the simple name of the superclass ca.uhn.hl7v2.model.primitive.TM |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_SUPERCLASS |
72-79 |
High |
ca.uhn.hl7v2.parser.CustomModelClassFactory
| Bug |
Category |
Details |
Line |
Priority |
| Return value of putIfAbsent is ignored, but retVal is reused in ca.uhn.hl7v2.parser.CustomModelClassFactory.getGroupClass(String, String) |
MT_CORRECTNESS |
RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED |
152 |
High |
| Return value of putIfAbsent is ignored, but retVal is reused in ca.uhn.hl7v2.parser.CustomModelClassFactory.getMessageClass(String, String, boolean) |
MT_CORRECTNESS |
RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED |
137 |
High |
| Return value of putIfAbsent is ignored, but retVal is reused in ca.uhn.hl7v2.parser.CustomModelClassFactory.getSegmentClass(String, String) |
MT_CORRECTNESS |
RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED |
167 |
High |
| Return value of putIfAbsent is ignored, but retVal is reused in ca.uhn.hl7v2.parser.CustomModelClassFactory.getTypeClass(String, String) |
MT_CORRECTNESS |
RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED |
182 |
High |
ca.uhn.hl7v2.parser.DefaultEscaping$1
| Bug |
Category |
Details |
Line |
Priority |
| Boxing/unboxing to parse a primitive new ca.uhn.hl7v2.parser.DefaultEscaping$1(int, float, boolean) |
PERFORMANCE |
DM_BOXED_PRIMITIVE_FOR_PARSING |
54 |
High |
| new ca.uhn.hl7v2.parser.DefaultEscaping$1(int, float, boolean) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
54 |
Medium |
ca.uhn.hl7v2.parser.DefaultModelClassFactory
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in ca.uhn.hl7v2.parser.DefaultModelClassFactory.loadPackages(String): new java.io.InputStreamReader(InputStream) |
I18N |
DM_DEFAULT_ENCODING |
268 |
High |
ca.uhn.hl7v2.parser.DefaultXMLParser
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in ca.uhn.hl7v2.parser.DefaultXMLParser.main(String[]): new java.io.FileReader(File) |
I18N |
DM_DEFAULT_ENCODING |
347 |
High |
| Possible null pointer dereference of inParser in ca.uhn.hl7v2.parser.DefaultXMLParser.main(String[]) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
367 |
Medium |
| Possible null pointer dereference of outParser in ca.uhn.hl7v2.parser.DefaultXMLParser.main(String[]) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
370 |
Medium |
ca.uhn.hl7v2.parser.FixFieldDataType
| Bug |
Category |
Details |
Line |
Priority |
| Format-string method String.format(String, Object[]) called with format string "A datatype for %s-%n must be specified in %s-%n." wants 2 arguments but is given 4 in ca.uhn.hl7v2.parser.FixFieldDataType.fix(Segment, int, int, String, String, ModelClassFactory, ParserConfiguration) |
CORRECTNESS |
VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED |
165 |
Medium |
ca.uhn.hl7v2.parser.OldPipeParser
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of fieldSepString, which is known to be non-null in ca.uhn.hl7v2.parser.OldPipeParser.doEncode(Message) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
444 |
Medium |
ca.uhn.hl7v2.parser.PipeParser
| Bug |
Category |
Details |
Line |
Priority |
| ca.uhn.hl7v2.parser.PipeParser.encode(Segment, EncodingCharacters, ParserConfiguration, String) concatenates strings using + in a loop |
PERFORMANCE |
SBSC_USE_STRINGBUFFER_CONCATENATION |
843 |
Medium |
| ca.uhn.hl7v2.parser.PipeParser.encode(Type, EncodingCharacters, ParserConfiguration, String) concatenates strings using + in a loop |
PERFORMANCE |
SBSC_USE_STRINGBUFFER_CONCATENATION |
560 |
Medium |
ca.uhn.hl7v2.preparser.DatumPath
| Bug |
Category |
Details |
Line |
Priority |
| ca.uhn.hl7v2.preparser.DatumPath.clone() does not call super.clone() |
BAD_PRACTICE |
CN_IDIOM_NO_SUPER_CALL |
266 |
Medium |
| ca.uhn.hl7v2.preparser.DatumPath.add(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
209 |
Medium |
| ca.uhn.hl7v2.preparser.DatumPath.main(String[]) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
307 |
Medium |
| ca.uhn.hl7v2.preparser.DatumPath defines equals and uses Object.hashCode() |
BAD_PRACTICE |
HE_EQUALS_USE_HASHCODE |
53-56 |
High |
| Useless condition: it's known that idx >= 1 at this point |
STYLE |
UC_USELESS_CONDITION |
106 |
Medium |
ca.uhn.hl7v2.preparser.ER7
| Bug |
Category |
Details |
Line |
Priority |
| ca.uhn.hl7v2.preparser.ER7.parseMSHSegmentWhole(Properties, List, EncodingCharacters, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
99 |
Medium |
| ca.uhn.hl7v2.preparser.ER7.parseSegmentGuts(ER7$Handler, String, List) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
254 |
Medium |
| ca.uhn.hl7v2.preparser.ER7.parseSegmentWhole(Properties, Map, List, EncodingCharacters, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
139 |
Medium |
| ca.uhn.hl7v2.preparser.ER7.parseMessage(Properties, List, String) invokes inefficient new String(String) constructor |
PERFORMANCE |
DM_STRING_CTOR |
63 |
Medium |
ca.uhn.hl7v2.preparser.ER7$ER7SegmentHandler
| Bug |
Category |
Details |
Line |
Priority |
| ca.uhn.hl7v2.preparser.ER7$ER7SegmentHandler.putDatum(List, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
212 |
Medium |
ca.uhn.hl7v2.preparser.XML$HL7MessageHandler
| Bug |
Category |
Details |
Line |
Priority |
| ca.uhn.hl7v2.preparser.XML$HL7MessageHandler.tryToGrowDocLocationFromElementName(StringBuffer, DatumPath, Map, DatumPath, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
284 |
Medium |
| ca.uhn.hl7v2.preparser.XML$HL7MessageHandler.clear() invokes inefficient new String() constructor |
PERFORMANCE |
DM_STRING_VOID_CTOR |
139 |
Medium |
ca.uhn.hl7v2.protocol.impl.ApplicationLoader
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in ca.uhn.hl7v2.protocol.impl.ApplicationLoader.loadApplications(ApplicationRouter, URL): new java.io.InputStreamReader(InputStream) |
I18N |
DM_DEFAULT_ENCODING |
81 |
High |
| ca.uhn.hl7v2.protocol.impl.ApplicationLoader.loadApplications(ApplicationRouter, URL) may fail to close stream |
BAD_PRACTICE |
OS_OPEN_STREAM |
81 |
Medium |
ca.uhn.hl7v2.protocol.impl.JMSTopicTransport
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: ca.uhn.hl7v2.protocol.impl.JMSTopicTransport.myMessageSelector |
PERFORMANCE |
URF_UNREAD_FIELD |
77 |
Medium |
ca.uhn.hl7v2.protocol.impl.JMSTransport
| Bug |
Category |
Details |
Line |
Priority |
| instanceof will always return true for all non-null values in ca.uhn.hl7v2.protocol.impl.JMSTransport.toMessage(Transportable), since all javax.jms.TextMessage are instances of javax.jms.TextMessage |
STYLE |
BC_VACUOUS_INSTANCEOF |
149 |
Medium |
ca.uhn.hl7v2.protocol.impl.ProcessorImpl
| Bug |
Category |
Details |
Line |
Priority |
| ca.uhn.hl7v2.protocol.impl.ProcessorImpl.reserve(String, long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
227 |
Medium |
| new ca.uhn.hl7v2.protocol.impl.ProcessorImpl(ProcessorContext, boolean) invokes Thread.start() |
MT_CORRECTNESS |
SC_START_IN_CTOR |
96 |
Medium |
| ca.uhn.hl7v2.protocol.impl.ProcessorImpl.cleanAcceptAcks() makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
399 |
Medium |
| ca.uhn.hl7v2.protocol.impl.ProcessorImpl.cleanReservations() makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
385 |
Medium |
| ca.uhn.hl7v2.protocol.impl.ProcessorImpl.cleanReservedMessages() makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
410 |
Medium |
ca.uhn.hl7v2.protocol.impl.ProcessorImpl$ExpiringTransportable
| Bug |
Category |
Details |
Line |
Priority |
| Should ca.uhn.hl7v2.protocol.impl.ProcessorImpl$ExpiringTransportable be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
486-489 |
Medium |
ca.uhn.hl7v2.protocol.impl.ReaderThread
| Bug |
Category |
Details |
Line |
Priority |
| new ca.uhn.hl7v2.protocol.impl.ReaderThread(Reader, char[], IntRef) may expose internal representation by storing an externally mutable object into ReaderThread.myBuffer |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
57 |
Medium |
ca.uhn.hl7v2.protocol.impl.URLTransport
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in ca.uhn.hl7v2.protocol.impl.URLTransport.doReceive(): new java.io.InputStreamReader(InputStream) |
I18N |
DM_DEFAULT_ENCODING |
126 |
High |
| Found reliance on default encoding in ca.uhn.hl7v2.protocol.impl.URLTransport.doSend(Transportable): new java.io.OutputStreamWriter(OutputStream) |
I18N |
DM_DEFAULT_ENCODING |
105 |
High |
| ca.uhn.hl7v2.protocol.impl.URLTransport.doSend(Transportable) may fail to close stream |
BAD_PRACTICE |
OS_OPEN_STREAM |
105 |
Medium |
ca.uhn.hl7v2.util.FileCodeMapper
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in ca.uhn.hl7v2.util.FileCodeMapper.refreshCache(): new java.io.FileReader(File) |
I18N |
DM_DEFAULT_ENCODING |
116 |
High |
| Dereference of the result of readLine() without nullcheck in ca.uhn.hl7v2.util.FileCodeMapper.refreshCache() |
STYLE |
NP_DEREFERENCE_OF_READLINE_VALUE |
119 |
Medium |
| Possible null pointer dereference in ca.uhn.hl7v2.util.FileCodeMapper.refreshCache() due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
84 |
Medium |
| Possible null pointer dereference in ca.uhn.hl7v2.util.FileCodeMapper.refreshCache() due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
105 |
Medium |
ca.uhn.hl7v2.util.Hl7InputStreamMessageStringIterator
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in new ca.uhn.hl7v2.util.Hl7InputStreamMessageStringIterator(InputStream): new java.io.InputStreamReader(InputStream) |
I18N |
DM_DEFAULT_ENCODING |
54 |
High |
ca.uhn.hl7v2.util.MessageIDGenerator
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in ca.uhn.hl7v2.util.MessageIDGenerator.getNewID(): new java.io.FileWriter(String, boolean) |
I18N |
DM_DEFAULT_ENCODING |
151 |
High |
| Found reliance on default encoding in ca.uhn.hl7v2.util.MessageIDGenerator.initialize(): new java.io.FileReader(String) |
I18N |
DM_DEFAULT_ENCODING |
94 |
High |
| Call to Boolean.equals(String) in ca.uhn.hl7v2.util.MessageIDGenerator.getNewID() |
CORRECTNESS |
EC_UNRELATED_TYPES |
156 |
High |
| Call to Boolean.equals(String) in ca.uhn.hl7v2.util.MessageIDGenerator.initialize() |
CORRECTNESS |
EC_UNRELATED_TYPES |
121 |
High |
| ca.uhn.hl7v2.util.MessageIDGenerator.initialize() may fail to clean up java.io.Reader on checked exception |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE |
94 |
Medium |
ca.uhn.hl7v2.util.XMLUtils$ClasspathResourceResolver
| Bug |
Category |
Details |
Line |
Priority |
| ca.uhn.hl7v2.util.XMLUtils$ClasspathResourceResolver.resolveResource(String, String, String, String, String) may fail to clean up java.io.InputStream |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION |
146 |
Medium |
ca.uhn.hl7v2.util.idgenerator.FileBasedGenerator
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in ca.uhn.hl7v2.util.idgenerator.FileBasedGenerator.readInitialValue(String): new java.io.InputStreamReader(InputStream) |
I18N |
DM_DEFAULT_ENCODING |
116 |
High |
| Found reliance on default encoding in ca.uhn.hl7v2.util.idgenerator.FileBasedGenerator.writeNextValue(long): new java.io.PrintWriter(OutputStream) |
I18N |
DM_DEFAULT_ENCODING |
97 |
High |
ca.uhn.hl7v2.util.idgenerator.HiLoGenerator
| Bug |
Category |
Details |
Line |
Priority |
| Inconsistent synchronization of ca.uhn.hl7v2.util.idgenerator.HiLoGenerator.base; locked 80% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
92 |
Medium |
| Inconsistent synchronization of ca.uhn.hl7v2.util.idgenerator.HiLoGenerator.lo; locked 80% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
91 |
Medium |
ca.uhn.hl7v2.util.idgenerator.NanoTimeGenerator
| Bug |
Category |
Details |
Line |
Priority |
| ca.uhn.hl7v2.util.idgenerator.NanoTimeGenerator.getID() calls Thread.sleep() with a lock held |
MT_CORRECTNESS |
SWL_SLEEP_WITH_LOCK_HELD |
41 |
Medium |
ca.uhn.hl7v2.validation.builder.RuleTypeBuilder$MessageExpressionBuilder$1
| Bug |
Category |
Details |
Line |
Priority |
| Class ca.uhn.hl7v2.validation.builder.RuleTypeBuilder$MessageExpressionBuilder$1 defines non-transient non-serializable instance field this$1 |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
ca.uhn.hl7v2.validation.impl.ConformanceProfileRule
| Bug |
Category |
Details |
Line |
Priority |
| Inconsistent synchronization of ca.uhn.hl7v2.validation.impl.ConformanceProfileRule.enableCaching; locked 50% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
194 |
Medium |
